Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (eb75e59) to head (2f9fecc).
Report is 20 commits behind head on main.

@@            Coverage Diff            @@
##              main      #268   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines         2121      2120    -1     
  Branches       543       543           
=========================================
- Hits          2121      2120    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I'm happy to approve this, but the fact that we need to transpose, flip, and flip the beam to get the pyuvdata analytic beam to match pyuvsim seems notable. I assume it's a massive overhaul to make pyuvsim use the pyuvdata beam convention? This is pyradiosky, not pyuvsim, so it shouldn't be a hold up on this PR -- but having different beam conventions floating around seems bad...

This is done internally in the visibility creation code in pyuvsim (in uvsim.py in the apply_beam method on the UVEngine object). It's not an externally available beam representation at all. The reason to do it here is so that I can just copy the code that creates the visibility from pyuvsim. I'm not entirely sure I understand why all this re-arrangement is done in pyuvsim, I think it's something to do with how the einsum is set up. If we want to fix it, we should do it in pyuvsim.